[ET-VK] Fix VulkanBackend args output index
#7297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one in the `VK_CHECK_COND` expression was wrong. Use a variable for easier tracking. Differential Revision: [D67126361](https://our.internmc.facebook.com/intern/diff/D67126361/) [ghstack-poisoned]
pytorch-bot
bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7297
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 007b848 with merge base de74961 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
junpi3
pushed a commit
that referenced
this pull request
Dec 12, 2024
The one in the `VK_CHECK_COND` expression was wrong. Use a variable for easier tracking. Differential Revision: [D67126361](https://our.internmc.facebook.com/intern/diff/D67126361/) ghstack-source-id: 257760376 Pull Request resolved: #7297
|
This pull request was exported from Phabricator. Differential Revision: D67126361 |
SS-JIA
approved these changes
Dec 12, 2024
The one in the `VK_CHECK_COND` expression was wrong. Use a variable for easier tracking. Differential Revision: [D67126361](https://our.internmc.facebook.com/intern/diff/D67126361/) [ghstack-poisoned]
junpi3
pushed a commit
that referenced
this pull request
Dec 12, 2024
Pull Request resolved: #7297 The one in the `VK_CHECK_COND` expression was wrong. Use a variable for easier tracking. ghstack-source-id: 257853133 @exported-using-ghexport Differential Revision: [D67126361](https://our.internmc.facebook.com/intern/diff/D67126361/)
|
This pull request was exported from Phabricator. Differential Revision: D67126361 |
The one in the `VK_CHECK_COND` expression was wrong. Use a variable for easier tracking. Differential Revision: [D67126361](https://our.internmc.facebook.com/intern/diff/D67126361/) [ghstack-poisoned]
junpi3
pushed a commit
that referenced
this pull request
Dec 12, 2024
Pull Request resolved: #7297 The one in the `VK_CHECK_COND` expression was wrong. Use a variable for easier tracking. ghstack-source-id: 257860131 @exported-using-ghexport Differential Revision: [D67126361](https://our.internmc.facebook.com/intern/diff/D67126361/)
|
This pull request was exported from Phabricator. Differential Revision: D67126361 |
facebook-github-bot
merged commit 1bf5d64
into
gh/jorgep31415/128/base
45 of 46 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Dec 16, 2024
Pull Request resolved: #7297 The one in the `VK_CHECK_COND` expression was wrong. Use a variable for easier tracking. ghstack-source-id: 257860131 @exported-using-ghexport Differential Revision: [D67126361](https://our.internmc.facebook.com/intern/diff/D67126361/) Co-authored-by: jorgep31415 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
argsoutput index #7297The one in the
VK_CHECK_CONDexpression was wrong. Use a variable for easier tracking.Differential Revision: D67126361